Repository navigation
Fix missing Linux AppImage and launcher icons - #31
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux AppImage shipped a logo but omitted
.DirIconand an icon-theme entry. The user-level launcher also referencedIcon=BetterMailwithout installing that icon, leaving launcher/dock icons unresolved.Include PNG
.DirIconmetadata in both AppImage packaging paths and the hicolor icon in release packages. On AppImage startup, install a persistent user icon andbettermail.desktopunder XDG_DATA_HOME (or ~/.local/share), pointing to the current AppImage path. Reuse this registration when choosing the default mail app, and match the X11 window class to StartupWMClass. Ordinary startup does not change default mail associations. Registration failures do not prevent startup.The launcher uses an absolute persistent icon path, supports moved AppImages and escaped filenames, and avoids temporary mount paths. File-manager thumbnails require AppImage support in the host file manager;
.DirIconnow supplies the expected metadata (AppDir specification).Validation:
.DirIcon, root logo, hicolor icon, and desktop metadata verified.