Skip to content

Keep mail search and startup responsive - #32

Merged
mrinc merged 1 commit into
masterfrom
fix/mail-search-freeze
Oct 3, 2026
Merged

mrinc merged 1 commit into
masterfrom
fix/mail-search-freeze

Conversation

@bcbetterninja

Copy link
Copy Markdown
Collaborator

Mail search could wait behind sync, keep writes blocked after cancellation, or fail with no such table: message_search when index migration finished ahead of a queued query. Give plain, mailbox and filtered mail searches a dedicated encrypted WAL reader, interrupt executing SQLite work on cancellation, and select the search index inside the same read snapshot as the query.

Restart could freeze the UI while Microsoft account setup waited on a token-cache lock or native keyring. Run setup off the UI thread with a 15-second timeout, expose cached mail before account setup completes, and show an actionable retry error if it stalls. Serialize concurrent setup attempts per provider and continue initializing other providers after a failure.

Validation:

  • Solution build passed with zero warnings/errors.
  • All 561 tests passed, including eight new cases for searches during active writes, migration across queued and active reads, executing/queued SQL cancellation, blocked account setup cancellation/timeout, and cached-mail access during failed or pending setup.
  • Linux startup smoke check passed using an isolated temporary profile under Xvfb.
  • Windows/macOS validation is covered by the PR CI matrix; no personal mail data was used.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b8846349-0599-4b6f-8037-ab656ebdaf43
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mrinc
mrinc merged commit 5ccf3b8 into master Oct 3, 2026
9 checks passed
@mrinc
mrinc deleted the fix/mail-search-freeze branch October 3, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants