Repository navigation
Allow dragging contacts between To, Cc and Bcc - #34
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3121414b57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recipient chips could not be dragged between To, Cc, and Bcc because compose had no recipient drag/drop handlers. Dragging a Cc contact onto To now moves the existing chip, keeps its display name, and saves/sends it in the destination field. All six field-to-field moves are supported.
The destination highlights during an accepted drag. Pending text in both fields is preserved; an address already present in the destination is merged without a duplicate. Clicking a chip also keeps the recipient input focused for typing. Same-field, unrelated, stale, and cross-compose drops are rejected, and sending/uploading prevents recipient moves. Recipient transfers use an in-process format without exposing contact text to unrelated drop targets.
Validation:
type:mailso unrelated workspace searches cannot reorder its collection during headless assertions. All 588 tests passed again, plus ten repeated runs of that regression.Also includes the test-only Windows cleanup fix from PR #36: the temporary legacy recovery fixture disables SQLite pooling so
mail.dbcan be deleted after disposal. This fixes the Windows blocker inherited from the merged PR #35 on the updated base.