Repository navigation
Conversation
|
2026-10-08 声明真实的受支持发行版;在其最老版本实际安装并启动打包结果,验证所有运行时依赖。 明确 Linux 失败是否允许阻断既有平台 latest.json;调整或记录该发布契约。 修复仓库外调用的默认版本读取,运行当前 head Linux job;CI 当前未实际执行。 |
BigPizzaV3
left a comment
There was a problem hiding this comment.
补充一个 P2:DEFAULT_VERSION 虽然按 REPO_DIR 检查了 package.json,但 node -p 仍使用当前工作目录下的相对路径。用户从仓库外调用脚本时会静默回退到 1.5.0,生成错误版本的 deb。
位置:scripts/installer/linux/build-deb.sh:14-18。
请改为基于 $PROJECT_DIR/package.json 的绝对路径,或先 cd "$REPO_DIR"。
|
当前 PR 与 |
BigPizzaV3
left a comment
There was a problem hiding this comment.
审查结论:Request changes。
[P2] Linux 打包脚本在仓库外执行时会生成错误版本。
scripts/installer/linux/build-deb.sh:14-18 虽然用绝对路径检查了 package.json,但 node -p 内部仍通过相对路径 require("./apps/codex-plus-manager/package.json")。从仓库外调用脚本时会静默回退到 1.5.0,生成错误版本的 deb。
请改为基于 PROJECT_DIR/package.json 的绝对路径,或先 cd 到 REPO_DIR;同时先 rebase 解决当前冲突,再运行 Linux 打包验证和现有平台 CI。
|
当前 P2 仍未解决:Linux 打包脚本从仓库外执行时,undefined 仍使用相对路径读取 package.json,可能静默生成 1.5.0 错误版本。请改用绝对路径或先切换到 REPO_DIR,并先解决冲突、补 Linux 验证和双平台 CI。 |
|
Thanks for working on Linux packaging! 感谢贡献 Linux 打包支持!目前 main 已经把管理器和启动器合并成单一程序 codex-plus-plus(7dd3d1e7),这个 PR 需要 rebase 并调整后才能合入:
|
Resolve PR BigPizzaV3#2386 against the latest upstream main without reverting Windows/macOS changes. Validate native amd64 DEB packaging on Ubuntu 24.04 and decouple Linux release from latest.json.
|
太强了,3332244这个commit可以正常使用了吗?准备clone来build一波 |
|
@caden-yang 目前在 目前在 Linux 本机上已实测验证通过了 Codex 的基础功能(包括桌面版识别、端口注入与双向通信)。不过对于 DeepSeek Herness 以及其他第三方 Agent Herness接入功能目前还没有进行测试,欢迎拉取最新代码一起编译测试和反馈! |
|
Thanks for the continued work on Linux! 感谢持续投入,打包脚本的版本读取和平台隔离都改进了不少。目前正式发布只覆盖 macOS 和 Windows,是否正式发布 Linux 产物需要维护者单独决定,所以请先拆分:
改完后我们会批准 workflow 跑一次 CI,再一起看。谢谢! |
|
感谢 @BigPizzaV3 详尽专业的 Review 意见!已在 commit
麻烦批准运行 CI,期待您的进一步指导! |
|
感谢持续跟进,release 工作流解耦、uid 过滤和新增测试都看到了!合入前还有几点:
改完后我们会批准 workflow 跑一次 CI,谢谢! |
5db34c9 to
acc7d53
Compare
|
感谢 @BigPizzaV3 的耐心审查与明确指引!本轮改动已完成全面重构并 clean rebase 至最新
目前前端及核心测试(包括 watcher 全量用例)均在本地通过,PR 当前状态为 |
acc7d53 to
b6e0901
Compare
|
补充汇报:已在 Fork 仓库完整实跑验证了
三大平台构建与测试已全量绿灯通过(Overall: |
7b36acb to
7d79f88
Compare
|
最新进展汇报:已将 CI 质量门禁对齐并推广至三大平台(Windows、macOS、Linux),在每个平台上均严格执行了前端全量测试 + TypeScript 检查 + Rust 全工作区全量测试(cargo test --workspace) + 发布打包校验,并在 Fork 仓库完成了全流程实跑:
三大平台全量测试与打包已全线绿灯通过(Overall: |
|
感谢快速跟进,uid 过滤、文档和英文翻译都看到了!还有几点:
改完我们会批准 workflow 跑 CI,谢谢! |
7d79f88 to
fa86611
Compare
|
感谢持续跟进,完整参数匹配、uid 过滤、文档和英文翻译都看到了。合入前还有三点:
改完我们会批准 workflow 跑 CI,谢谢! |
9925d47 to
316730c
Compare
|
感谢跟进,按端口结束和 /proc 读取都看到了!还有几点:
CI 我们先批准运行。谢谢! |
316730c to
e3c92f7
Compare
|
感谢跟进,starttime、结束前复核以及删掉 ps 解析函数都看到了,上一版 CI 三个平台也都通过了。还有几处小收尾:
改完我们会再批准 CI,谢谢! |
e3c92f7 to
abae8f1
Compare
|
感谢跟进,三处收尾都看到了,本地 macOS 测试通过。CI 已经批准运行,三个平台通过后,我们会在这次发版之后合入。谢谢! |
abae8f1 to
5ac74e6
Compare
…, and CI workflows - Linux desktop process detection: token-by-token argv parsing via tokenize_args and /proc/<pid>/cmdline verification; strict debug flag matching (--remote-debugging-pipe, --remote-debugging-port=<u16>, --remote-debugging-port <u16>); removed /usr/lib/codex/ from whitelist; comprehensive unit tests covering quoted arguments and non-desktop sessions. - Process lifecycle & auto takeover: single-instance and multi-worker instance management on Linux via /proc/<pid>/cmdline and /proc/<pid>/exe inspection, with graceful SIGTERM and forceful SIGKILL escalation. - Autostart & shortcuts: standard FreeDesktop XDG .desktop entry creation, installation to ~/.local/share/applications and ~/Desktop, and mime-type registration. - Packaging & CI: modular build-deb.sh supporting directory-independent invocation, automated package.json version parsing, exact Installed-Size calculation, and complete CI gate (Ubuntu 24.04, amd64) verifying build, package integrity, and runtime dependencies. - Reverted out-of-scope macOS helper changes and PR build additions to keep existing platforms 100% untouched.
5ac74e6 to
8286b7e
Compare
Summary
This PR introduces native Linux packaging, comprehensive desktop runtime adaptation, and CI workflows for CodexPlusPlus:
scripts/installer/linux/build-deb.sh):codex-plus-plusexecutable, desktop files, icons, and autostart entries into a standard Debian.debpackage.PROJECT_DIR/package.json) preventing silent fallback to outdated versions when invoked outside repo root..linux-build/as local build workspace to avoid colliding with existing ignores..github/workflows/pr-build.yml: Added Linux validation job verifying frontend build,cargo build --release -p codex-plus-manager, external/tmpDebian package assembly, package file layout, installation, and binary symbol linkage (ldd)..github/workflows/release-assets.yml: Added Linux.debartifact generation. Explicitly excludedlinux-debfromlatest-jsonneeds so Linux build status does not block Windows / macOS release manifests.watcher.rs,multi_worker.rs).app_paths.rs).computer_use.rs,computer_use_commands.rs,auto_takeover.rs)..linux-build/to.gitignore.Verification & Testing
cargo test -p codex-plus-core --lib,cargo test -p codex-plus-manager --lib,cargo test -p codex-plus-launcher)..debpackage built, installed viadpkg -i, and verified on live Linux desktop with active Codex injection and bi-directional communication.