Repository navigation
Conversation
130040167
force-pushed
the
codex/codex-lifecycle-continuity-pr-20261028
branch
from
October 28, 2026 12:20
24f361c to
a82153b
Compare
Owner
|
感谢投入这么多验证工作。这个 PR 目前体量(约 5300 行)超出了能可靠审查的范围,建议在 #2735 定稿后拆成:主实例身份与停止/重启、包上下文启动与 CODEX_HOME 校验、Windows worker 交接协议、启动顺序与 UI 四部分。另外有几处需要先调整:
|
130040167
marked this pull request as ready for review
October 28, 2026 14:01
130040167
marked this pull request as draft
October 28, 2026 14:14
Contributor
Author
|
按维护建议关闭当前大型生命周期 PR,后续拆分为主实例身份与启停重启、启动上下文/CODEX_HOME、worker 交接协议、启动顺序与 UI 四个独立 PR,并逐项处理当前审查意见。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
退出旧管理器再启动更新后的管理器时,原生 Codex 桌面可能仍在运行,但 helper/worker 已断开;CDP 不可用时,停止或重启又可能误判为已经退出,留下残留进程或重复启动。此修改按已保存的桌面身份重新连接,并在确认旧进程树退出后才启动替代实例。
依赖 #2735 的进程身份与安全清理接口。当前提交历史包含该前置提交,前置合入后需移除依赖差异。显式 Electron 多开目录隔离配合 #2732 使用;微信功能独立维护。
Windows 验证:
17cabdc3升级到80c2dfdd,均保持原 Codex 桌面进程和原 thread ID,升级前后两条回复保存在同一份原生历史中。两侧构建均来自干净提交,后者包含当前上游8c2b5b5d。没有将真实供应商、真实微信或跨平台行为计入上述模拟验收。首次 worker 验收曾在空白兄弟窗口的模型菜单处超时;补强为两个窗口都创建并续接会话后通过,不能据此排除所有空白页加载问题。