Skip to content

Linux Fixes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schlick7 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Linux Fixes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209e3f9
Enhance audio extraction for non-Windows platforms
schlick7 Jan 17, 2026
b7938f6
Refactor FFmpeg path setup to use Path.Combine
schlick7 Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions AudioExtractor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Diagnostics;
using System.IO;
using System.Runtime.InteropServices;
using NAudio.Wave;

namespace SubtitleCreator
Expand All @@ -28,6 +29,12 @@ public static string ExtractAudioFromVideoFile(string videoFilePath, bool attemp
string newVideoFilePath = videoFilePath;
bool tempFileCreated = false;

if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
Utilities.ConsoleWithLog("Running on non-Windows platform, using ffmpeg for audio extraction.");
return ExtractAudioWithFfmpeg(videoFilePath, ffmpegPath);
}

if (Path.GetExtension(videoFilePath).ToLower() == ".mkv")
{
Utilities.ConsoleWithLog("Input file is in a MKV container. Extracting the video.");
Expand Down Expand Up @@ -129,7 +136,7 @@ private static string RepairAudio(string videoFilePath, string ffmpegPath)
// Set up the process to run FFmpeg
using (Process ffmpeg = new Process())
{
ffmpeg.StartInfo.FileName = $"\"{ffmpegPath}\\ffmpeg\"";
ffmpeg.StartInfo.FileName = Path.Combine(ffmpegPath, "ffmpeg");
ffmpeg.StartInfo.Arguments = ffmpegArgs;
ffmpeg.StartInfo.RedirectStandardError = true;
ffmpeg.StartInfo.UseShellExecute = false;
Expand All @@ -155,7 +162,7 @@ private static string ExtractVideoFromMKV(string videoFilePath, string ffmpegPat
// Set up the process to run FFmpeg
using (Process ffmpeg = new Process())
{
ffmpeg.StartInfo.FileName = $"\"{ffmpegPath}\\ffmpeg\"";
ffmpeg.StartInfo.FileName = Path.Combine(ffmpegPath, "ffmpeg");
ffmpeg.StartInfo.Arguments = ffmpegArgs;
ffmpeg.StartInfo.RedirectStandardError = true;
ffmpeg.StartInfo.UseShellExecute = false;
Expand All @@ -171,5 +178,26 @@ private static string ExtractVideoFromMKV(string videoFilePath, string ffmpegPat

return intermediateFilePath;
}

private static string ExtractAudioWithFfmpeg(string videoFilePath, string ffmpegPath)
{
outputFilePath = Path.Combine(Path.GetDirectoryName(videoFilePath) ?? string.Empty, $"{Path.GetFileNameWithoutExtension(videoFilePath)}{fileNameIdentifier}.wav");
string ffmpegArgs = $"-i \"{videoFilePath}\" -vn -acodec pcm_s16le -ar 16000 -ac 1 \"{outputFilePath}\"";

using (Process ffmpeg = new Process())
{
ffmpeg.StartInfo.FileName = Path.Combine(ffmpegPath, "ffmpeg");
ffmpeg.StartInfo.Arguments = ffmpegArgs;
ffmpeg.StartInfo.RedirectStandardError = true;
ffmpeg.StartInfo.UseShellExecute = false;
ffmpeg.StartInfo.CreateNoWindow = true;

ffmpeg.Start();
string output = ffmpeg.StandardError.ReadToEnd();
ffmpeg.WaitForExit();
}

return outputFilePath;
}
}
}
2 changes: 1 addition & 1 deletion CreateTheSubtitles.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public bool DoWorkMergeSubtitles(string srtFile, string inFile, string finalFile
// Set up the process to run FFmpeg
using (Process ffmpeg = new Process())
{
ffmpeg.StartInfo.FileName = $"\"{ffmpegPath}\\ffmpeg\"";
ffmpeg.StartInfo.FileName = Path.Combine(ffmpegPath, "ffmpeg");
ffmpeg.StartInfo.Arguments = ffmpegArgs;
ffmpeg.StartInfo.RedirectStandardError = true;
ffmpeg.StartInfo.UseShellExecute = false;
Expand Down