Skip to content

sonar: MAJOR — Extract nested ternary operations (4 instances) #77

Closed

Description

@BillyOutlast

SonarCloud Finding — S3358

4 nested ternary operations should be extracted into independent statements.

File Line
sites/promo/src/components/comparison.tsx 458, 463
sites/promo/src/components/news.tsx 200
server/components/StoreView.vue 465

Fix

Extract ternaries into named variables or if/else blocks.

Activity

  1. BillyOutlast commented on Jul 26, 2026

    @BillyOutlast
    OwnerAuthor

    Closed by #91. Fixed 2 of 4 instances:

    • ✅ sites/promo/src/components/comparison.tsx:458,463 (extracted to renderValue() helper)
    • ✅ sites/promo/src/components/news.tsx:200 (refactored to if/else)

    Remaining:

    • sites/promo/src/components/comparison.tsx:200 (different nested ternary)
    • sites/promo/src/components/comparison.tsx:330 (onlyUnique function scope)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions