Repository navigation
fix(chain-config): saving subscription refreshes + duplicate id confirm - #11
Merged
Merged
Conversation
Gaubee
commented
Dec 17, 2025
Contributor
- Save subscription URL now triggers an immediate fetch (caches with ETag via existing service)\n- Manual add shows duplicate-id confirmation (replace/cancel)\n- Tests: unit store/page + e2e chain-config-subscription\n- i18n: add duplicate dialog strings (en/zh-CN/zh-TW/ar)
- 保存订阅 URL 后自动拉取订阅配置(符合 chain-config spec)\n- 手动添加遇到重复 chain id 时弹窗确认(替换/取消)\n- 补齐单测与 e2e(chain-config-subscription)\n- 补齐 i18n 文案(en/zh-CN/zh-TW/ar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.