Repository navigation
fix: resolve asset URLs relative to document.baseURI - #122
Merged
Merged
Conversation
- Add resolveAssetUrl utility to handle relative paths for GitHub Pages deployment - Update IconProvidersWrapper to resolve chain icon and token icon base URLs - Fixes icons showing as /icons/... instead of /KeyApp/webapp/icons/... on gh-pages
Gaubee
force-pushed
the
fix/base-url-icons
branch
from
December 26, 2025 07:56
bb7ae73 to
6e8dfd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
在 GitHub Pages 部署时，以
/开头的图标路径（如/icons/ethereum/chain.svg）会解析为根路径https://bioforestchain.github.io/icons/...，而不是正确的https://bioforestchain.github.io/KeyApp/webapp/icons/...。解决方案
resolveAssetUrl工具函数，基于document.baseURI解析相对路径IconProvidersWrapper中预处理链配置，将icon和tokenIconBase路径解析为完整 URL改动
src/lib/asset-url.ts: 新增 URL 解析工具函数src/lib/asset-url.test.ts: 工具函数单元测试src/frontend-main.tsx: 在 Provider 层应用路径解析