Repository navigation
fix(icons): resolve icon paths relative to JSON config file - #123
Merged
Merged
Conversation
- Add resolveRelativePath() and resolveIconPaths() in chain-config service - Resolve icon and tokenIconBase paths relative to JSON file URL when loading - Add isSameOrigin() check in token-icon to distinguish local vs CDN resources - Update default-chains.json to use relative paths (../icons/...) This ensures icons work correctly regardless of deployment subpath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Icon paths like
/icons/bfchainv2/tokens/bft.svgfail when deployed to subpaths (e.g.,/KeyApp/webapp/).Solution
Resolve icon paths relative to the JSON config file location instead of document.baseURI:
resolveRelativePath()andresolveIconPaths()in chain-config serviceisSameOrigin()in token-icon to distinguish local (.svg) vs CDN (icon-*.png) resources../icons/...)Changes
src/services/chain-config/index.ts: Add path resolution logicsrc/components/wallet/token-icon.tsx: Add same-origin detectionpublic/configs/default-chains.json: Use relative pathsCloses the 404 issue for token icons on GitHub Pages.