Skip to content

fix(forge): add disclaimer and sort chains BSC -> TRON -> ETH #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaubee merged 4 commits into from
Jan 4, 2026
Merged

fix(forge): add disclaimer and sort chains BSC -> TRON -> ETH #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e127538
fix(forge): add disclaimer and sort chains BSC -> TRON -> ETH
Gaubee Jan 4, 2026
ac7edfe
fix(forge): remove incorrect disclaimer copy
Gaubee Jan 4, 2026
9120285
test(forge): update chain order expectations in tests
Gaubee Jan 4, 2026
6a951a0
test(forge): update storybook test for BNB-first chain ordering
Gaubee Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions miniapps/forge/src/App.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,16 +258,16 @@ export const TokenPicker: Story = {

await userEvent.click(canvas.getByRole('button', { name: /连接钱包/i }))

// Wait for token selector button
// Wait for token selector button (BSC/BNB is now first due to chain ordering)
await waitFor(
() => {
expect(canvas.getByText('ETH')).toBeInTheDocument()
expect(canvas.getByText('BNB')).toBeInTheDocument()
},
{ timeout: 5000 }
)

// Click token selector to open picker
const tokenButton = canvas.getAllByRole('button').find((btn) => btn.textContent?.includes('ETH'))
const tokenButton = canvas.getAllByRole('button').find((btn) => btn.textContent?.includes('BNB'))
if (tokenButton) {
await userEvent.click(tokenButton)
}
Expand Down
9 changes: 5 additions & 4 deletions miniapps/forge/src/hooks/useRechargeConfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,17 @@ describe('useRechargeConfig', () => {
const options = result.current.forgeOptions
expect(options).toHaveLength(2) // ETH and BSC enabled, TRON disabled

// Chain order: BSC -> TRON -> ETH
expect(options[0]).toMatchObject({
externalChain: 'ETH',
externalAsset: 'ETH',
externalChain: 'BSC',
externalAsset: 'BNB',
internalChain: 'bfmeta',
internalAsset: 'BFM',
})

expect(options[1]).toMatchObject({
externalChain: 'BSC',
externalAsset: 'BNB',
externalChain: 'ETH',
externalAsset: 'ETH',
internalChain: 'bfmeta',
internalAsset: 'BFM',
})
Expand Down
6 changes: 6 additions & 0 deletions miniapps/forge/src/hooks/useRechargeConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ export interface ForgeOption {
logo?: string
}

/** Chain display order: BSC -> TRON -> ETH */
const CHAIN_ORDER: Record<string, number> = { BSC: 1, TRON: 2, ETH: 3 }

/**
* Parse recharge config to forge options
*/
Expand All @@ -52,6 +55,9 @@ function parseForgeOptions(config: RechargeConfig): ForgeOption[] {
}
}

// Sort by chain order: BSC -> TRON -> ETH
options.sort((a, b) => (CHAIN_ORDER[a.externalChain] ?? 99) - (CHAIN_ORDER[b.externalChain] ?? 99))

return options
}

Expand Down