Repository navigation
Conversation
Previously, errors in getNativeBalance and getTokenBalance were silently swallowed and returned 0 balance. This made debugging impossible. Changes: - Log errors to console.error with chain, address, and RPC URL info - Add debug logging in DEV mode for tracing balance queries - This will help diagnose why customer assets are not showing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Customer reports external chain assets (ETH/BSC) not showing in the wallet.
Investigation revealed that the EVM asset service silently swallows errors:
This makes debugging impossible - we don't know if the RPC failed, returned an error, or what went wrong.
Changes
console.errorlogging when balance queries fail (includes chain, address, RPC URL)console.debuglogging in DEV mode to trace query executionTesting
pnpm turbo run lint:run typecheck:run- passespnpm turbo run test:run- all 69+ tests passNext Steps
After merging, customer can: