Repository navigation
fix(wallet): show 'not supported' instead of loading for unsupported providers - #181
Merged
Merged
Conversation
…cks capability - Fix transactionsLoading logic: use AND instead of OR condition - When provider.supportsTransactionHistory is false, show fallback warning immediately - Update etherscan-v2 status to 'normal' in whitebook (API key configured)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a provider doesn't support transaction history (like
ethereum-rpc), the UI shows infinite loading instead of a 'not supported' message.Root Cause
In
wallet-address-portfolio-from-provider.tsx:When
transactionsEnabled = false,transactionsLoadingis alwaystrue.Fix
transactionsEnabled && transactionsQuery.isLoadingChanges
src/components/wallet/wallet-address-portfolio-from-provider.tsxdocs/white-book/04-服务篇/01-服务架构/api-providers-status.md