Skip to content

openspec: add app lock (password-only MVP) - #2

Closed
Gaubee wants to merge 1 commit into
mainfrom
openspec/add-app-lock
Closed

Gaubee wants to merge 1 commit into
mainfrom
openspec/add-app-lock

Conversation

@Gaubee

@Gaubee Gaubee commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Spec-only PR for approval. No implementation included.

In-scope (MVP): Settings toggle + /lock route + router guard + cold-start enforcement (no protected flash) + password verification via decrypting existing wallet secret (no raw password storage).

Out-of-scope (deferred): fingerprint flows; resume-timeout semantics parity with mpay.

Decision needed: approve/decline this scope before any implementation (T028).

@Gaubee Gaubee added documentation Improvements or additions to documentation question Further information is requested labels Dec 15, 2025
@Gaubee

Gaubee commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

Decision ask (approve/decline): App Lock (password-only MVP) spec.

Key points:

  • In-scope: Settings toggle + /lock route + router guard + cold-start enforcement (no protected flash) + password verification via decrypting existing wallet secret (no raw password storage).
  • Out-of-scope (deferred): fingerprint flows; mpay resume-timeout semantics.
  • Security scope: treat /authorize/** as protected when locked; unlock then return to original authorize route.
  • Cold-start safety: guard MUST load persisted wallet state before deciding "no wallet" (avoid bypass).

@Gaubee

Gaubee commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Decision needed (IN/OUT for MVP parity): Story 6.1 App Lock = startup unlock flow.

  • PDR Story 6.1: ‘下次打开 App 需要验证密码’. In KeyApp, Settings has an ‘应用锁’ entry but it’s still TODO.
  • This PR (openspec: add app lock (password-only MVP) #2) is spec-only. If App Lock is IN for this MVP/parity cycle: please approve/merge; we’ll implement as password-only MVP (biometric / fingerprint-payment deferred).
  • If App Lock is OUT for this MVP: we’ll close PR openspec: add app lock (password-only MVP) #2 and update POR wording (R6/Now) to avoid “parity achieved but pending”.

@Gaubee

Gaubee commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Decision (2025-12-16): App Lock is OUT for current MVP (no startup/resume lock). Closing this spec-only PR; we can reopen/recreate when it becomes IN.

@Gaubee Gaubee closed this Dec 16, 2025
@Gaubee

Gaubee commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

kf/kzf 决策:AppLock 本轮 MVP 先 OUT(不做启动/恢复锁)。本 PR(openspec: add app lock)先关闭,后续若需要再按 OpenSpec 重新开启/新提案。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant