Repository navigation
fix(bioforest): add per-chain genesisBlock config support - #201
Merged
Merged
Conversation
- Add bfmetav2.json genesis block file - Add config.genesisBlock field to biowallet API entries in default-chains.json - Modify fetchGenesisBlock to accept optional genesisBlockPath parameter - Add chainConfigService.getBiowalletGenesisBlock() method - Update BioforestTransactionService to pass genesisBlock config This allows each chain to specify a custom genesis block path relative to the configs directory, fixing the 404 issue when chainId doesn't match the genesis filename. Fixes #194
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Genesis block 404 error when deploying to GitHub Pages - the chainId (e.g.,
bfmetav2) doesn't always match the genesis filename (e.g.,bfmeta.json).Solution
config.genesisBlockfield to biowallet API entries indefault-chains.jsonfetchGenesisBlockto accept optionalgenesisBlockPathparameterchainConfigService.getBiowalletGenesisBlock()methodbfmetav2.jsongenesis block fileChanges
public/configs/default-chains.json: AddedgenesisBlockconfig to all bioforest chainspublic/configs/genesis/bfmetav2.json: New genesis block file for BFMeta V2src/services/bioforest-sdk/index.ts: Support optionalgenesisBlockPathparametersrc/services/chain-config/service.ts: AddgetBiowalletGenesisBlock()methodsrc/services/chain-adapter/bioforest/transaction-service.ts: Pass genesisBlock configFixes #194