Repository navigation
chore(e2e): add permission tests and Mobile Safari screenshots - #203
Merged
Merged
Conversation
Add tests documenting the manifest permission validation behavior: - Verify attach stores manifest permissions correctly - Document permission rules (account method mapping, system method bypass) - Reference PR #202 fix for forge miniapp bio_signMessage issue
Generate baseline screenshots for Mobile Safari E2E tests. This complements PR #200 which added Safari test configuration. Note: Some tests are skipped or flaky on Safari due to: - Forge miniapp API loading differences - Input clearing behavior differences The CI currently runs only Mobile Chrome for speed, but these baselines enable local Safari testing for visual regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two issues raised in the code review:
1. PR #202 - Test Driven Development
Added tests documenting the manifest permission validation behavior in
bridge.test.ts:bio_signMessagefixNote: The actual permission rejection is tested via E2E tests since
processRequestis private and MessageEvent simulation has jsdom limitations.2. PR #200 - Mobile Safari Screenshots
Generated baseline screenshots for Mobile Safari E2E tests (83 new files):
e2e/__screenshots__/Mobile-Safari/directory with all mock test baselinesImportant notes:
Mobile Chromefor speed (e2e:ciande2e:ci:mock)pnpm e2e:mock --project 'Mobile Safari'Testing