Skip to content

ci: add Mobile Safari to E2E test matrix #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaubee merged 1 commit into from
Jan 10, 2026
Merged

ci: add Mobile Safari to E2E test matrix #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ jobs:

- name: Install Playwright
if: steps.changes.outputs.code == 'true' && steps.playwright-cache.outputs.cache-hit != 'true'
run: pnpm exec playwright install --with-deps chromium
run: pnpm exec playwright install --with-deps chromium webkit

- name: Install Playwright deps
if: steps.changes.outputs.code == 'true' && steps.playwright-cache.outputs.cache-hit == 'true'
run: pnpm exec playwright install-deps chromium
run: pnpm exec playwright install-deps chromium webkit

- name: Run all checks
env:
Expand Down
Binary file added e2e/screenshots/address-book-page.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added e2e/screenshots/scanner-page.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added e2e/screenshots/send-page-scanner-button.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
"e2e:run": "playwright test",
"e2e:mock": "playwright test --config playwright.mock.config.ts",
"e2e:mock:run": "playwright test --config playwright.mock.config.ts",
"e2e:ci": "playwright test --project 'Mobile Chrome'",
"e2e:ci:mock": "playwright test --config playwright.mock.config.ts --project 'Mobile Chrome'",
"e2e:ci": "playwright test --project 'Mobile Chrome' --project 'Mobile Safari'",
"e2e:ci:mock": "playwright test --config playwright.mock.config.ts --project 'Mobile Chrome' --project 'Mobile Safari'",
"e2e:ci:real": "playwright test --config playwright.real.config.ts",
"e2e:real": "playwright test --config playwright.real.config.ts",
"e2e:ui": "playwright test --ui",
Expand Down