Repository navigation
fix(token-item): avoid button nesting when menuItems present - #211
Merged
Merged
Conversation
When TokenItem has menuItems (DropdownMenuTrigger renders as button), the outer Item cannot also be a button. Now Item renders as div when menuItems exist, with a clickable div wrapper for the content area. Also update biwmeta API endpoint from walletapi.biw-meta.com to walletapi.bfmeta.info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
首页启动时出现 React hydration 错误:
错误堆栈显示:
Root Cause
当
TokenItem同时有onClick(使 Item 渲染为 button)和menuItems(内部有 DropdownMenuTrigger button)时,会导致 button 嵌套。这与 PR #210 修复的问题不同:
DropdownMenuTrigger > Button > button嵌套Item(button) > DropdownMenuTrigger(button)嵌套Solution
当有
menuItems时,Item渲染为<div>而不是<button>,点击区域通过内部的role="button"div 实现:Additional Changes
更新 biwmeta API endpoint:
walletapi.biw-meta.com→walletapi.bfmeta.infoTesting