Skip to content

fix(ci): include packages/ and miniapps/ in change detection - #218

Merged
Gaubee merged 1 commit into
mainfrom
fix/ci-detection-improvements
Jan 11, 2026
Merged

Gaubee merged 1 commit into
mainfrom
fix/ci-detection-improvements

Conversation

@Gaubee

@Gaubee Gaubee commented Jan 11, 2026

Copy link
Copy Markdown
Contributor

Problem

During key-ui development, we discovered that CI change detection only monitored src/ and e2e/ directories. This meant:

  1. Changes to packages/key-ui or packages/key-utils didn't trigger full CI runs
  2. Changes to miniapps/forge or miniapps/teleport were also missed
  3. This could lead to broken builds passing CI if only package files changed

Solution

Extended change detection patterns in both CI paths:

Self-hosted (ci-fast):

# Before
grep -E '^src/|^e2e/'

# After  
grep -E '^src/|^e2e/|^packages/|^miniapps/'

GitHub-hosted (ci-standard):

# Before
code:
  - 'src/**'
  - 'e2e/**'

# After
code:
  - 'src/**'
  - 'e2e/**'
  - 'packages/**'
  - 'miniapps/**'

Impact

  • Full CI (including E2E tests) will now run when any code in the monorepo changes
  • Prevents false positives where package-only PRs skip important checks

Previously CI only detected changes in src/ and e2e/, missing:
- packages/key-ui, packages/key-utils changes
- miniapps/forge, miniapps/teleport changes

This caused issues where package changes wouldn't trigger full CI runs.
@Gaubee
Gaubee merged commit 07bd1bb into main Jan 11, 2026
5 checks passed
@Gaubee
Gaubee deleted the fix/ci-detection-improvements branch January 11, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant