Repository navigation
fix(turbo): improve cache invalidation with package.json and lockfile - #219
Merged
Merged
Conversation
Changes: - Add globalDependencies for pnpm-lock.yaml to invalidate all caches when dependencies change - Add package.json to inputs for lint, typecheck, test tasks to detect dependency changes per package - Add .storybook/** to test:storybook inputs This prevents stale cache hits when workspace dependencies change, which caused issues during key-ui development where adding new dependencies didn't trigger re-typecheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During key-ui development, we encountered issues where:
package.jsondidn't invalidate turbo cacheSolution
1. Global lockfile dependency
Any change to the lockfile now invalidates all caches globally.
2. Per-package dependency tracking
Added
package.jsonto inputs for:lint:runtypecheck:runtest:runtest:storybook3. Storybook config tracking
Added
.storybook/**totest:storybookinputs.Impact
Verification
pnpm turbo run typecheck:run --filter=@biochain/key-ui # Cached: 0 cached, 6 total (cache properly invalidated)