Skip to content

fix: handleChainId returns selected chain ID - #232

Merged
Gaubee merged 1 commit into
mainfrom
fix/wallet-handler-chainid-1419737835341673945
Jan 16, 2026
Merged

Gaubee merged 1 commit into
mainfrom
fix/wallet-handler-chainid-1419737835341673945

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This change fixes the issue where handleChainId was returning a hardcoded 'bfmeta' string. It now retrieves the currently selected chain ID from the walletStore. A new unit test has been added to verify this behavior.


PR created automatically by Jules for task 1419737835341673945 started by @Gaubee

- Updated `handleChainId` in `src/services/ecosystem/handlers/wallet.ts` to return `walletStore.state.selectedChain` instead of hardcoded 'bfmeta'.
- Added unit test `src/services/ecosystem/handlers/wallet.test.ts`.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Gaubee Gaubee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 代码变更简洁,修复了硬编码的 chain ID 问题,测试覆盖完整。

@Gaubee
Gaubee marked this pull request as ready for review January 16, 2026 02:15
@Gaubee
Gaubee merged commit e71a0d8 into main Jan 16, 2026
5 checks passed
@Gaubee
Gaubee deleted the fix/wallet-handler-chainid-1419737835341673945 branch January 16, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant