Skip to content

Fix E2E test locator for 'Confirm Send' button #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

Fix E2E test locator for 'Confirm Send' button #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 46 additions & 61 deletions e2e/send-transaction.mock.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ const TEST_WALLET_DATA = {
chain: 'ethereum',
address: '0x71C7656EC7ab88b098defB751B7401B5f6d8976F',
tokens: [
{ symbol: 'ETH', balance: '1.5', decimals: 18 },
// Mock a larger balance to ensure tests pass
{ symbol: 'ETH', balance: '10', decimals: 18 },
{ symbol: 'USDT', balance: '1000', decimals: 6, contractAddress: '0xdAC17F958D2ee523a2206206994597C13D831ec7' },
],
},
Expand Down Expand Up @@ -325,51 +326,39 @@ test.describe('发送交易 - Job 弹窗流程', () => {
const { addressInput, amountInput } = await getSendPageInputs(page)

// 填写有效数据
await addressInput.fill('0x1234567890abcdef1234567890abcdef12345678')
await addressInput.fill('0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045') // Use a valid address
await amountInput.fill('0.1')

// 等待费用估算
await page.waitForTimeout(1000)

const continueBtn = page.locator('[data-testid="send-continue-button"]')

// Continue button should be enabled
await expect(continueBtn).toBeEnabled()
await continueBtn.click()

// 等待 TransferConfirmJob 出现
// Job 应该包含金额和确认按钮
await page.waitForTimeout(500)

// 检查确认弹窗内容 (use job-specific test-ids)
const confirmBtn = page.locator('[data-testid="job-confirm-transfer-button"]')
const cancelBtn = page.locator('[data-testid="job-cancel-transfer-button"]')

// 确认和取消按钮应该可见
await expect(confirmBtn).toBeVisible()
await expect(cancelBtn).toBeVisible()

// 检查按钮是否启用
const isEnabled = await continueBtn.isEnabled()

if (isEnabled) {
await continueBtn.click()

// 等待 TransferConfirmJob 出现
// Job 应该包含金额和确认按钮
await page.waitForTimeout(500)

// 检查确认弹窗内容
const confirmBtn = page.locator('[data-testid="confirm-transfer-button"]')
const cancelBtn = page.locator('[data-testid="cancel-transfer-button"]')

// 至少一个按钮应该可见（确认或取消）
const hasConfirmUI = await confirmBtn.isVisible() || await cancelBtn.isVisible()

if (hasConfirmUI) {
console.log('TransferConfirmJob opened successfully')

// 截图
await expect(page).toHaveScreenshot('send-confirm-job.png')

// 点击取消应该关闭弹窗
if (await cancelBtn.isVisible()) {
await cancelBtn.click()
await page.waitForTimeout(300)

// 应该回到发送页面
await expect(page.locator('[data-testid="send-continue-button"]')).toBeVisible()
}
} else {
console.log('TransferConfirmJob may not have opened - check mock configuration')
}
} else {
console.log('Continue button not enabled - mock service may not be configured correctly')
}
// 截图
await expect(page).toHaveScreenshot('send-confirm-job.png')

// 点击取消应该关闭弹窗
await cancelBtn.click()
await page.waitForTimeout(300)

// 应该回到发送页面
await expect(page.locator('[data-testid="send-continue-button"]')).toBeVisible()
})

test('确认后显示钱包锁 Job', async ({ page }) => {
Expand All @@ -379,33 +368,29 @@ test.describe('发送交易 - Job 弹窗流程', () => {
const { addressInput, amountInput } = await getSendPageInputs(page)

// 填写有效数据
await addressInput.fill('0x1234567890abcdef1234567890abcdef12345678')
await addressInput.fill('0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045') // Use a valid address
await amountInput.fill('0.1')

await page.waitForTimeout(1000)

const continueBtn = page.locator('[data-testid="send-continue-button"]')

// Continue button should be enabled
await expect(continueBtn).toBeEnabled()
await continueBtn.click()
await page.waitForTimeout(500)

const confirmBtn = page.locator('[data-testid="job-confirm-transfer-button"]')
await expect(confirmBtn).toBeVisible()

await confirmBtn.click()
await page.waitForTimeout(500)

// 应该显示钱包锁
const patternInput = page.locator('[data-testid="wallet-pattern-input"], input[type="password"]')
await expect(patternInput).toBeVisible()

if (await continueBtn.isEnabled()) {
await continueBtn.click()
await page.waitForTimeout(500)

const confirmBtn = page.locator('[data-testid="confirm-transfer-button"]')

if (await confirmBtn.isVisible()) {
await confirmBtn.click()
await page.waitForTimeout(500)

// 应该显示钱包锁
const patternInput = page.locator('[data-testid="wallet-pattern-input"], input[type="password"]')

if (await patternInput.isVisible()) {
console.log('WalletLockConfirmJob opened successfully')
await expect(page).toHaveScreenshot('send-wallet-lock-job.png')
} else {
console.log('WalletLockConfirmJob may not have opened')
}
}
}
// 截图
await expect(page).toHaveScreenshot('send-wallet-lock-job.png')
})
})
4 changes: 2 additions & 2 deletions src/stackflow/activities/sheets/TransferConfirmJob.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ function TransferConfirmJobContent() {
<div className="flex gap-3">
<button
type="button"
data-testid="cancel-transfer-button"
data-testid="job-cancel-transfer-button"
onClick={handleClose}
className="border-border hover:bg-muted flex-1 rounded-full border py-3 font-medium transition-colors"
disabled={isConfirming}
Expand All @@ -202,7 +202,7 @@ function TransferConfirmJobContent() {
</button>
<button
type="button"
data-testid="confirm-transfer-button"
data-testid="job-confirm-transfer-button"
onClick={handleConfirm}
disabled={isConfirming || feeLoading}
className={cn(
Expand Down