Repository navigation
fix: use dynamic genesis beginEpochTime for BioChain transaction timestamps - #243
Merged
Merged
Conversation
…stamps BREAKING: Transaction timestamps for non-BFM chains now display correctly. Previously all BioChain transactions used a hardcoded 2017-01-01 epoch. Now each chain uses its genesis block's beginEpochTime. Changes: - biowallet-provider.ts: Added epochMs member, fetch beginEpochTime from genesis - time-display.tsx: Added timeZoneName to datetime format for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BioChain transaction timestamps were calculated using a hardcoded 2017-01-01 epoch, which is incorrect for chains like
biwmetaandbfmetathat have different genesis times.Solution
beginEpochTimefrom each chain's genesis block configurationepochMsmember variable inBiowalletProviderAdditional Changes
TimeDisplaycomponent now includes timezone info (timeZoneName: 'short') to avoid ambiguityTesting