Repository navigation
fix(ecosystem): restore slider position memory with proper Swiper sync lifecycle - #259
Merged
Merged
Conversation
- Change key-utils to export src/*.ts directly (no build needed) - Fix remote miniapp icon/screenshot URL handling with proper URL check - Absolute URLs (http/https) are preserved, relative paths use new URL()
…c lifecycle - Rewrite swiper-sync-context with ready-based lifecycle management - Controller connection only established after both Swipers are ready - slideTo with runCallbacks=false to prevent triggering slideChange during init - onSlideChange callback only fires after ready state is set - Remove controller prop from Swiper, use native API for connection - Fix setAvailableSubPages to not override activeSubPage - Fix key-ui package to export TS source directly like other key-* packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swiper-sync-contextwith ready-based lifecycle management to fix EcosystemTab slider position not being remembered after page refreshkey-uipackage to export TS source directly like otherkey-*packagesProblem
The EcosystemTab slider position was always resetting to "discover" on page refresh, even though the value was correctly saved in localStorage. The root cause was the Swiper Controller module triggering
slideChangeevents during initialization, which overwrote the savedactiveSubPagevalue.Solution
Implemented a new Swiper sync lifecycle:
slideTo(initialIndex, 0, false)onSlideChangeonly fires after ready state is set, filtering out initialization eventscontrollerprop from Swiper, useswiper.controller.controldirectlyChanges
swiper-sync-context.tsxuseSwiperMember(selfId, targetId, options)APIecosystem-desktop.tsxcontrollerpropTabBar.tsxswiper-sync-demo.tsxstores/ecosystem.tssetAvailableSubPagesno longer overridesactiveSubPagekey-ui/package.json