Skip to content

Fix CD release asset upload idempotency #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaubee merged 1 commit into from
Jan 27, 2026
Merged

Fix CD release asset upload idempotency #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,14 +422,21 @@ jobs:
fi
if gh release view "$TAG_NAME" >/dev/null 2>&1; then
release_json=$(gh api "repos/${{ github.repository }}/releases/tags/$TAG_NAME")
upload_files=()
for file in "${release_files[@]}"; do
name=$(basename "$file")
asset_id=$(echo "$release_json" | jq -r --arg name "$name" '.assets[] | select(.name==$name) | .id')
if [ -n "$asset_id" ] && [ "$asset_id" != "null" ]; then
gh api -X DELETE "repos/${{ github.repository }}/releases/assets/$asset_id" || true
echo "Release asset exists, skip upload: $name"
continue
fi
upload_files+=("$file")
done
gh release upload "$TAG_NAME" "${release_files[@]}"
if [ "${#upload_files[@]}" -eq 0 ]; then
echo "All release assets already exist, skip upload"
else
gh release upload "$TAG_NAME" "${upload_files[@]}"
fi
else
gh release create "$TAG_NAME" \
--title "$RELEASE_TITLE" \
Expand Down Expand Up @@ -944,14 +951,21 @@ jobs:
fi
if gh release view "$TAG_NAME" >/dev/null 2>&1; then
release_json=$(gh api "repos/${{ github.repository }}/releases/tags/$TAG_NAME")
upload_files=()
for file in "${release_files[@]}"; do
name=$(basename "$file")
asset_id=$(echo "$release_json" | jq -r --arg name "$name" '.assets[] | select(.name==$name) | .id')
if [ -n "$asset_id" ] && [ "$asset_id" != "null" ]; then
gh api -X DELETE "repos/${{ github.repository }}/releases/assets/$asset_id" || true
echo "Release asset exists, skip upload: $name"
continue
fi
upload_files+=("$file")
done
gh release upload "$TAG_NAME" "${release_files[@]}"
if [ "${#upload_files[@]}" -eq 0 ]; then
echo "All release assets already exist, skip upload"
else
gh release upload "$TAG_NAME" "${upload_files[@]}"
fi
else
gh release create "$TAG_NAME" \
--title "$RELEASE_TITLE" \
Expand Down