Repository navigation
feat: Epic #80 - 弹出层组件架构重构与转账流程修复 - #87
Merged
Merged
Conversation
- Replace custom BottomSheet component with Stackflow wrapper - Convert all sheet components to Activities: - TransferConfirmSheetActivity (new) - All imports now from @/components/layout/bottom-sheet - Update pages to use Activity-based sheets: - HomePage uses ChainSelectorSheetActivity - SendPage uses TransferConfirmSheetActivity + PasswordConfirmSheetActivity - Delete redundant component files: - transfer-confirm-sheet, password-confirm-sheet - mnemonic-options-sheet, wallet-edit-sheet - contact-edit-sheet, bottom-sheet tests/stories Closes #81
- Create src/components/layout/modal.tsx as Stackflow Modal wrapper - Clarify usage patterns: - Stackflow Modal/BottomSheet: navigation-based Activities - shadcn AlertDialog: inline state-controlled dialogs - Keep existing shadcn alert-dialog for inline confirmations Closes #82
- Rename all *SheetActivity files to *Job: - ChainSelectorJob, WalletRenameJob, WalletDeleteJob - PasswordConfirmJob, MnemonicOptionsJob, ContactEditJob - WalletAddJob, SecurityWarningJob, TransferConfirmJob - Update routes from /sheet/* to /job/* - Update all push() calls across the codebase Job naming convention indicates shared business activities used across multiple pages. Closes #83
- Fix TransferConfirmJob: pop first, then call callback This ensures correct stack order when pushing PasswordConfirmJob - Remove goBack() call after submit success submit() already sets state.step to 'result' Flow now: 1. TransferConfirmJob pops itself 2. PasswordConfirmJob pushes onto stack 3. After password verify, submit() sets state to 'result' 4. PasswordConfirmJob pops itself 5. SendPage shows result Closes #84
- Add logging for debugging API issues - Handle multiple response formats (data.transactions or transactions) - Log specific errors instead of silent failures - Add debug logging when no transactions found This helps diagnose why transactions might not be showing. Closes #85
- Add test for TransferConfirmJob opening after form submit - Add test for PasswordConfirmJob opening after confirm - Tests handle cases where mock service isn't fully configured - Add screenshot tests for new Job UI Closes #86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
重构弹出层组件架构，统一使用 Stackflow 导航系统，修复转账流程问题。
变更内容
#81 重构 BottomSheet 组件架构
src/components/layout/bottom-sheet.tsx改为 Stackflow BottomSheet 包装TransferConfirmJob#82 重构 Modal/AlertDialog 组件架构
src/components/layout/modal.tsx作为 Stackflow Modal 包装#83 重组 SheetActivity 文件结构
*SheetActivity为*Job/sheet/*改为/job/*#84 修复密码确认后交易流程
#85 修复交易列表查询
#86 补充转账流程 e2e 测试
测试结果
Closes #80, #81, #82, #83, #84, #85, #86