fix: use query params for GET address-book methods#9084
Merged
Conversation
seanchen0818
added a commit
that referenced
this pull request
Jun 22, 2026
- Replace .send(params) with .query(params) in getConnections, getListingEntryContacts, and getListingEntryDirectory so filters are sent as URL query params rather than request body GN-2899 #9084
seanchen0818
force-pushed
the
GN-2899-sdk-getconnections-query-params
branch
from
c2e224f to
f8046c6
Compare
Contributor
|
Tests failing |
seanchen0818
added a commit
that referenced
this pull request
Jun 22, 2026
- Replace .send(params) with .query(params) in getConnections, getListingEntryContacts, and getListingEntryDirectory so filters are sent as URL query params rather than request body GN-2899 #9084
seanchen0818
force-pushed
the
GN-2899-sdk-getconnections-query-params
branch
from
f8046c6 to
1b395d7
Compare
seanchen0818
added a commit
that referenced
this pull request
Jun 22, 2026
- Replace .send(params) with .query(params) in getConnections, getListingEntryContacts, and getListingEntryDirectory so filters are sent as URL query params rather than request body GN-2899 #9084
seanchen0818
force-pushed
the
GN-2899-sdk-getconnections-query-params
branch
from
1b395d7 to
e3b92e2
Compare
seanchen0818
added a commit
that referenced
this pull request
Jun 22, 2026
- Replace .send(params) with .query(params) in getConnections, getListingEntryContacts, and getListingEntryDirectory so filters are sent as URL query params rather than request body GN-2899 #9084
seanchen0818
force-pushed
the
GN-2899-sdk-getconnections-query-params
branch
from
e3b92e2 to
6ad97d5
Compare
seanchen0818
added a commit
that referenced
this pull request
Jun 22, 2026
- Replace .send(params) with .query(params) in getConnections, getListingEntryContacts, and getListingEntryDirectory so filters are sent as URL query params rather than request body GN-2899 #9084
seanchen0818
force-pushed
the
GN-2899-sdk-getconnections-query-params
branch
from
6ad97d5 to
9fd3f2c
Compare
lokesh-bitgo
left a comment
lokesh-bitgo
left a comment
Contributor
There was a problem hiding this comment.
The core fix is correct — .send(params) on GET was silently dropping all filter params since most servers ignore the request body on GET requests. .query(params ?? {}) is the right approach. CI is green and the logic is sound.
Leaving a few non-blocking suggestions inline.
seanchen0818
force-pushed
the
GN-2899-sdk-getconnections-query-params
branch
from
9fd3f2c to
6c6b2fa
Compare
- Replace .send(params) with .query(params) in getConnections, getListingEntryContacts, and getListingEntryDirectory so filters are sent as URL query params rather than request body GN-2899 #9084
seanchen0818
force-pushed
the
GN-2899-sdk-getconnections-query-params
branch
from
6c6b2fa to
3fe461e
Compare
pranishnepal
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getConnections,getListingEntryContacts, andgetListingEntryDirectorywere using.send(params)on GET requests, which puts params in the request body — ignored by the server.query(params)so filters are correctly sent as URL query paramsquery:, notbody:Test plan
.query()is called with the provided paramsFixes GN-2899
🤖 Generated with Claude Code