Repository navigation
On a phone the block panel's hide button shares the tab row, and the install card stays off an open world view - #309
Merged
Merged
Conversation
…nstall card stays off an open world view The width buttons, the hide button and the tabs are rendered and pressed (a hide that no longer hides, or an open sheet hidden on a phone, now fails). The view's wiring, the dim rows on tokens, the view root's marker and the install card's rule are pinned. Red on the base until the code lands.
…button shares the tab row The panel's widths, its sheet below md and its root's classes now come from world/panel-frame.ts, and the width buttons, the hide button and the tabs from world/PanelBar.tsx, which a render test presses. From md up the two rows stay where they were. Below md the hide button sits at the right of the tab row, so the sheet shows about three fact rows instead of one. A visitor who asked for less motion no longer sees the panel slide. The GAMING tab shows its word without an icon.
The world view's root says it is there and the install card carries its own marker; one rule in globals.css hides the card while a world view is in the page. The card's visit count, its dismissal and its timer are unchanged, so going back to the map shows it again when it is due.
The parcel heading, GLOW, the height legend and its last line, and every fact row's value read in the site's text tokens instead of fixed greys, so they are easier to read on the dark panel. A highlighted value stays orange.
ESTATE, the Coinbase type, the Coinbase legend line and the drag hint keep their words and lose the small pictures in front of them.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Gates
Gates: tsc 0, eslint 0 errors, jest 3,528 passed, 9 skipped, 0 failed (the world view's suites 32 with 409 tests), build green, same route list (155 routes); the new tests fail on the old code and pass now.