Cross-platform ComfyUI start/restart hook + Linux (NVIDIA GB10) setup guide - #27
Open
ondrejZach wants to merge 1 commit into
Open
ondrejZach wants to merge 1 commit into
ondrejZach wants to merge 1 commit into
Conversation
…rt/restart hook + launcher + guide Mix Studio's server is portable (zero-dependency Node, no build step), but the UI's Start/Restart ComfyUI actions were Windows-only (Comfy Desktop / run_nvidia_gpu.bat / taskkill). On Linux DGX-class devices (NVIDIA GB10 — DGX Spark, ASUS Ascent GX10; aarch64, sm_121) none of those exist. - lib/comfy-restart.js: when MIXBOX_COMFY_RESTART_CMD / MIXBOX_COMFY_START_CMD are set, restartStatus/startStatus report a 'command' kind and restart/startComfy run it via /bin/sh -c. No behavior change unless the env vars are set; Windows paths untouched. - start-mixstudio.sh: Linux launcher (counterpart to start.bat), env-overridable. - test/comfy-restart-command-hook.test.js: covers the hook, incl. never invoking taskkill. - docs/linux-dgx-gb10.md: prerequisites, launcher, systemd --user units, ComfyUI notes.
|
Will this work on another nvidia gpu on linux? |
Author
It shouldn’t be GB10 machine specific but I’m not sure 100% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mix Studio's server is already portable — zero-dependency Node, no build step — but the UI's Start / Restart ComfyUI actions are Windows-only (Comfy Desktop /
run_nvidia_gpu.bat/taskkill). On Linux DGX-class devices (NVIDIA GB10 — DGX Spark, ASUS Ascent GX10;sm_121, aarch64) none of those exist, so the buttons stay disabled.This adds an env-driven command hook so those actions work on any platform, a Linux launcher, and a setup guide for the path the Windows bootstrapper doesn't cover.
Changes
lib/comfy-restart.js— whenMIXBOX_COMFY_RESTART_CMD/MIXBOX_COMFY_START_CMDare set,restartStatus/startStatusreport acommandkind andrestartComfy/startComfyrun it via/bin/sh -c(e.g. asystemctl --userunit). No behavior change unless the env vars are set — the Windows detection/paths are untouched.start-mixstudio.sh— Linux launcher (counterpart tostart.bat): putsnodeonPATH, exports the config, enables the restart hooks,execsnode server.js. Every setting has a${VAR:-default}fallback.test/comfy-restart-command-hook.test.js— covers the hook and asserts it never falls back totaskkill.docs/linux-dgx-gb10.md— prerequisites, the launcher, systemd--userunits, and a brief ComfyUI-backend appendix (version needed for Krea 2, commonly-missing custom-node deps, shared model root).Testing
node --check server.js,node --check public/app.js, andnode --testall pass (893 tests). The launcher was verified to boot Mix Studio and connect to a local ComfyUI.Notes
sm_121ComfyUI/PyTorch stack for GB10 is left to NVIDIA's DGX Spark resources (the guide links there and gives a verify command).