Preserve installed plugin when cancellation wins before publish - #16
Draft
Blackspirits wants to merge 1 commit into
Draft
Preserve installed plugin when cancellation wins before publish#16Blackspirits wants to merge 1 commit into
Blackspirits wants to merge 1 commit into
Conversation
|
@Blackspirits Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
This pull request makes plugin replacement cancellation-safe, preserving installed plugins before commit and completing replacements once publishing begins.
Changes:
- Adds cancellation-aware plugin publishing.
- Adds regression tests for cancellation and replacement behavior.
File summaries
| File | Summary |
|---|---|
tests/UI/Logic/Plugins/PluginDownloadServiceTests.cs |
Covers cancellation preservation and normal replacement. |
src/ui/Logic/Plugins/PluginDownloadService.cs |
Implements safe plugin publication. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin installation can currently delete the installed copy, observe cancellation, and exit before the replacement is moved into place.
This change:
Validation
PluginDownloadServiceTestspassedAI assistance: ChatGPT was used to audit the cancellation/state-transition flow and prepare the regression-focused fix.