Protect multi-stream VOB outputs from accidental overwrite - #17
Draft
Blackspirits wants to merge 1 commit into
Draft
Protect multi-stream VOB outputs from accidental overwrite#17Blackspirits wants to merge 1 commit into
Blackspirits wants to merge 1 commit into
Conversation
|
@Blackspirits Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Protects multi-stream VOB outputs from accidental overwrite by validating generated numbered paths in VobSubExtractor.
Changes:
- Adds overwrite checks for numbered
.suband.idxoutputs. - Propagates the overwrite setting through
SubtitleConverter. - Adds regression coverage for multi-stream output handling.
File summaries
| File | Summary |
|---|---|
tests/seconv/Core/VobSubExtractorTest.cs |
Tests numbered output protection and unused base paths. |
src/seconv/Core/VobSubExtractor.cs |
Builds and validates generated stream output paths. |
src/seconv/Core/SubtitleConverter.cs |
Passes overwrite handling to the extractor. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current preflight checks only the unnumbered base output path. Multi-stream extraction writes numbered paths such as
movie.0.sub/.idxandmovie.1.sub/.idx, so existing numbered outputs can be overwritten even without--overwrite.This change moves overwrite protection into
VobSubExtractorafter actual output names are known.Validation
VobSubExtractorTestpassedAI assistance: ChatGPT was used to audit the VOB output flow, prepare the fix, and add regression coverage.