Reset current Settings.json from Windows installer - #18
Closed
Blackspirits wants to merge 1 commit into
Closed
Conversation
|
@Blackspirits Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
🟢 Approval recommended
The focused compatibility fix has no unresolved blocking issues.
Pull request overview
Updates the Windows installer reset flow to support current Settings.json files while retaining legacy XML compatibility.
Changes:
- Detects either settings format.
- Deletes both files when reset is selected.
File summaries
| File | Summary |
|---|---|
installer/WindowsInno/Subtitle_Edit_Installer.iss |
Updates reset detection and cleanup rules. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by internal PR #67, which carries the Windows installer settings-reset fix on current upstream base
fa6d8623c2adb0c646b6d31a11b221b855339bbe. The affected installer file was unchanged from the reviewed base, so the exact one-file fix was ported; it resets currentSettings.jsonwhile retaining legacySettings.xmlcleanup and passes restore/build/full-suite CI on the first run (#34725476046). This draft is retained only as historical evidence and must not be merged.