Allow explicit NTSC for VOB extraction - #22
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
|
@Blackspirits Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are covered by tests and no unresolved issues remain.
Pull request overview
Adds explicit PAL/NTSC selection for VOB extraction while preserving PAL as the default.
Changes:
- Adds
--vob-paland--vob-ntscwith conflict validation. - Propagates the selected standard through conversion.
- Updates documentation and regression tests.
File summaries
| File | Description |
|---|---|
tests/seconv/Core/VobSubExtractorTest.cs |
Tests defaults, NTSC selection, and conflicts. |
src/seconv/Helpers/HelpDisplay.cs |
Documents the new options. |
src/seconv/Core/SubtitleConverter.cs |
Passes the selected standard to extraction. |
src/seconv/Commands/ConvertCommand.cs |
Defines and validates the CLI options. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VOB extraction currently hard-codes PAL timing. There is no reliable PAL/NTSC auto-detection from VOB data alone without IFO parsing.
This follow-up adds explicit
--vob-paland--vob-ntscoptions while preserving PAL as the default for backwards compatibility. Conflicting flags are rejected.This PR is intentionally based on the separate multi-stream overwrite fix so its diff contains only the NTSC behavior change.
Validation
AI assistance: ChatGPT was used to audit the VOB video-standard path and prepare the regression-tested follow-up.