Verify Windows libmpv release downloads - #23
Conversation
|
@Blackspirits Thanks for sending me some feedback. Unfortunately, I hit an error while trying to use the custom Copilot setup steps configured for this repository. The error I am seeing is: Once you or someone with the necessary access fixes the problem, please let me know in a comment and I'll try again. Thanks! |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues remain.
Pull request overview
This pull request hardens the Windows release workflow by verifying SHA-256 digests for pinned x64 and ARM64 libmpv ZIPs before extraction.
Changes:
- Adds checksum validation for both libmpv assets.
- Prevents extraction when verification fails.
File summaries
| File | Description |
|---|---|
.github/workflows/build-ui.yml |
Verifies both libmpv archives before packaging. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Independent adversarial re-review completed against current upstream context.
No blocker found. Keep this PR as an internal draft; no merge/promotion performed. |
Summary
The Windows release workflow downloads the pinned x64 and ARM64 libmpv ZIPs and extracts them without validating the downloaded bytes.
This change pins the SHA-256 digest of both assets from the
libmpv-2026-08-14bsupport-files release and verifies each ZIP before extraction.Pinned digests:
ce99ee7a9cab0ada2f696b04132def67b0978157d5f4a1a7966d04c92aebbfecd8be93f69eb102026ba81d5d237887b858701510c9e5e26996a2d30f9829df00Validation
libmpv-2.dllAI assistance: ChatGPT was used to audit release download verification, retrieve the GitHub-published asset digests, and prepare this minimal workflow hardening change.