Verify CrispEmbed runtime downloads before install - #31
Draft
Blackspirits wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrispEmbed runtime archives are downloaded by
CrispEmbedDownloadServiceand unpacked immediately by the OCR installer. The matching SHA-256 values already exist inDownloadHashManager, but the downloaded archive bytes were not authenticated before extraction.This change:
Validation
sha256:digests published by the officialCrispStrobe/CrispEmbedv0.17.9 release; all seven matchBase is upstream
10b4b012fdb1e31edbff09ab69370c1c50ed9374. Upstream has since advanced, but the intervening commits do not touch the CrispEmbed runtime download/hash/install path.AI assistance: ChatGPT was used to audit the CrispEmbed runtime download/install paths, compare the pinned hashes with official GitHub release asset digests, prepare the minimal integrity fix, and add regression coverage.