Verify Paddle OCR downloads before unpack - #32
Draft
Blackspirits wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paddle OCR standalone engines and bundled OCR models are downloaded to a temporary folder and unpacked after only existence/non-empty checks. The upstream
timminator/PaddleOCR-Standalonev3.7.0 release publishes SHA-256 digests for every asset Subtitle Edit downloads, including both volumes of the Linux CUDA 12 archive.This change:
Validation
timminator/PaddleOCR-Standalonev3.7.0Base is upstream
10b4b012fdb1e31edbff09ab69370c1c50ed9374. Upstream later advanced toc38daaf93ff5b36e361619e7e336afc4b52b80c0; those intervening commits only change Voikko/build packaging and do not touch Paddle OCR or the integrity path.AI assistance: ChatGPT was used to audit the Paddle OCR download/unpack flow, verify official GitHub release digests, implement per-asset integrity checks including multipart archives, and add regression coverage.