Verify Tesseract runtime before install - #36
Draft
Blackspirits wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subtitle Edit downloads its pinned Windows Tesseract 5.5.3 runtime archive into memory, then removes the old Windows binaries and unpacks the downloaded stream. The official support-files release publishes a SHA-256 digest for that archive, but the downloaded bytes were not authenticated before the destructive install step.
This change:
Tesseract553.zipValidation
SubtitleEdit/support-filesreleasetesseract553Base is current upstream
c38daaf93ff5b36e361619e7e336afc4b52b80c0.AI assistance: ChatGPT was used to audit the Tesseract runtime download/install path, verify the support-files release digest, implement the minimal integrity check, and add regression coverage.