Verify Kokoro model downloads before publish - #37
Draft
Blackspirits wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kokoro TTS downloads two pinned model assets directly into their final file names. The upstream
koth/kokoro.cppvoices_model_filesrelease publishes SHA-256 digests for both assets, but the downloaded bytes were not authenticated. A failed/partial direct-to-final download could also leave a file that later existence checks treated as installed.This change:
kokoro-v1.1-zh.onnxandvoices-v1.1-zh.bin.partfileValidation
kokoro-v1.1-zh.onnxSHA-256 independently matched the GitHub release asset digest:eefec708cbc7aba8e8129b5c2f7cb92e1fe7d281af1e1dd451592d9ff0714a0dvoices-v1.1-zh.binSHA-256 independently matched the GitHub release asset digest:e678019845e6cfe3b7c34531779396b28f509451b91e6535d5dc09bbf11a4be5Base is current upstream
c38daaf93ff5b36e361619e7e336afc4b52b80c0.AI assistance: ChatGPT was used to audit the Kokoro model download/install path, verify official GitHub release digests, add atomic verified publication, and add regression coverage.