feat: /report_usages route and the usage_data_opt_out shared setting [User issue investigation] - #52
Open
PetrDlouhy wants to merge 2 commits into
Open
feat: /report_usages route and the usage_data_opt_out shared setting [User issue investigation]#52PetrDlouhy wants to merge 2 commits into
PetrDlouhy wants to merge 2 commits into
Conversation
The Blender add-on's save/render presence report (BlenderKit/Blendkit#2296) had no Client route of its own and rode the generic non-blocking wrapper, which agajdosi rejected. /report_usages forwards the `report` field untouched to the server's /api/v1/scene_save_reports/ as a "report_usages" task, like every other specialised route. Sending usage data from the user's machine needs an opt-out that every host shares (Blender, Maya, Unreal, Godot...), so it is a Shared setting, `usage_data_opt_out`, settable through /settings/set and broadcast with the settings snapshot. The Client enforces it: with the opt-out set, /report_usages drops the report without creating a task, so a host add-on cannot forget to honour it. Zero value keeps sending, so existing installs are unaffected. Only the usage report is wired to the setting; whether /report_event (telemetry) should follow is Michal's call. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Tweekazoid
approved these changes
Sep 11, 2026
Contributor
|
za me dobry, jen je potreba prvne mergnout tohle do mastru a potom updatovat branch v addonu na main opet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two things from the review of BlenderKit/Blendkit#2296 (the add-on's save/render presence report):
wrappers/nonblocking_requesttask type. It now has its own route and task type, like every other route here.What changed
POST /report_usages(+ versioned alias): forwards thereportfield untouched to/api/v1/scene_save_reports/with the standard headers as areport_usagestask; finish/error come back through the task stream likeratings/send_rating. Anonymous add-ons send noAuthorization.Shared.usage_data_opt_out(bool, zero value = keep sending, so existing installs are unaffected). Set viaPOST /settings/set {"usage_data_opt_out": true}, broadcast in the settings snapshot on every/report. The Client enforces it: with the opt-out set,/report_usagesanswers 200 and creates no task.docs/API.md/docs/openapi.json, five tests (usage_report_test.go).go vet,gofmt, full suite green under Go 1.26.Deliberately not done
/report_event(login-funnel telemetry) is also machine-side data and is the obvious next candidate, but that is a product decision: @Tweekazoid, your call whether it goes under the same switch./settings/set; the Blender add-on does that in Blendkit#2296.Release
The add-on pins the
v1.12minor and resolves the patch at build time, so a patch release with this is picked up by the next add-on build. Blendkit#2296 must not be released before that.🤖 Generated with Claude Code