Repository navigation
feat(grading): validate tutor review scores and feedback (BA-043) - #1035
Open
ranjeetprabhatedu-dotcom wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #956 (BA-043) by enforcing score bounds (0–100 integer) and required feedback/reason validation on tutor reviews with comprehensive boundary test coverage.
BackendAcademy/src/grading/dto/tutor-review.dto.ts: Addedfeedbackfield with class-validator decorators, validated score bounds (0 to 100), and enforced required feedback/reason rules for override decisions.BackendAcademy/src/grading/grading.controller.ts: Validated integer score bounds (0 <= score <= 100) and enforced non-empty feedback/reason requirements for override decisions before delegating toGradingService.BackendAcademy/src/grading/grading.service.spec.ts: Added unit tests verifying boundary scores (0, 100), rejection of negative, >100, and fractional scores, missing feedback/reason rejection, and feedback field equivalence.grading.service.spec.tspass cleanly (100% Green).Closes #956