Repository navigation
feat(health): BA-113 validate health endpoint query parameters and reject unsupported probe options - #1046
Open
ranjeetprabhatedu-dotcom wants to merge 1 commit into
Conversation
…ject unsupported probe options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements BA-113 to validate query parameters on the health check endpoint, rejecting unsupported probe options while cleanly handling accepted defaults and diagnostic options.
probequery options againstSUPPORTED_PROBES(liveness,readiness,startup,full), throwingBadRequestExceptionon unrecognized values.fullprobe when parameter is omitted.verbosequery parameter support returning system uptime and Node version for telemetry inspection.coverage.tsto useHttpExceptionwithHttpStatus.TOO_MANY_REQUESTS.app.controller.spec.tscovering default probe behavior, supported probe acceptance, unsupported probe rejection with detailed error messaging, and verbose flag output.BackendAcademy/src/health/health.controller.tsBackendAcademy/src/health/coverage.tsBackendAcademy/src/app.controller.spec.tsCloses #1026