Repository navigation
added bound - #1048
Merged
MaryammAli merged 1 commit intoOct 17, 2026
Merged
added bound#1048MaryammAli merged 1 commit into
MaryammAli merged 1 commit into
Conversation
|
@koder-ns Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Reject Oversized JSON Bodies with a Documented Client Error — API, Health & Shared Behavior
Problem / opportunity closes #1031
The API currently accepts arbitrarily large JSON request bodies on all inbound endpoints. This exposes the service to a class of avoidable risks:
Scope (strict allowlist) closes #1032
This PR is limited to exactly these three files:
| File | Role | closes #1030
|---|---|
|
BackendAcademy/src/main.ts| Enforce the JSON body size limit at bootstrap via the underlying HTTP adapter, and normalize the rejection into a documented client error. ||
BackendAcademy/src/app.module.ts| Wire the shared configuration (limit value / provider) so the behavior is centralized and testable. | closes #1033|
BackendAcademy/src/app.controller.spec.ts| Regression tests proving oversized bodies are rejected with the documented status and payload, and that valid bodies still pass. closes #1033No DTOs, filters, interceptors, guards, or config files outside this list are modified. Any necessary types are declared inline within these three files.
Implementation outline
BackendAcademy/src/main.ts413response shape rather than leaking a framework-specific error.except/catchwithout logging.BackendAcademy/src/app.module.tsBackendAcademy/src/app.controller.spec.ts413with documented{ code, message, limitBytes }.main.ts.Testing requirements
except:/catchwithout logging; rejection path emits a structured log entry.black,ruff,mypy(or the project's configured linters/type-checkers) on the touched files.Risk & rollback