Skip to content

Shorten Home screen title when needed - #309

Open
oroderico wants to merge 1 commit into
Blockstream:masterfrom
oroderico:test-pr274-home-fingerprint-no-jade
Open

oroderico wants to merge 1 commit into
Blockstream:masterfrom
oroderico:test-pr274-home-fingerprint-no-jade

Conversation

@oroderico

Copy link
Copy Markdown
Contributor

Note: opening this now so it is ready for review after the 1.0.41 release, as discussed in #274.

Description

The Home status bar title can be clipped on displays where the full Jade <fingerprint> device name does not fit.

This keeps the full Jade <fingerprint> title when it fits. If it would be clipped, the Home screen falls back to showing only the fingerprint. The full device name remains unchanged elsewhere.

Approach

  • Measure the Home title with GUI_TITLE_FONT.
  • Compare it against the status-bar title column width.
  • Strip only the Jade prefix when the full title would not fit.
  • Keep the change scoped to the Home activity title.

Testing

  • Tested on Waveshare S3 Touch LCD2: the Home title falls back to the fingerprint-only title as intended.
  • git diff --check

Comment thread main/ui/dashboard.c Outdated
Comment thread main/ui/dashboard.c Outdated
@oroderico
oroderico force-pushed the test-pr274-home-fingerprint-no-jade branch from 7989340 to e15c7f4 Compare July 11, 2026 16:40
@oroderico

Copy link
Copy Markdown
Contributor Author

Updated, thanks!

@oroderico

Copy link
Copy Markdown
Contributor Author

Hi @jgriffiths, just checking in — is there anything else you'd like adjusted here, or is this good to go?

@jgriffiths

Copy link
Copy Markdown
Collaborator

Hi @oroderico Just merged a commit from our 1.0.42 branch to master, which fixes v2 devices with long IDs (e.g. all alpha characters).

If you can rebase that, you'll need to tweak your HOME_SCREEN_STATUS_BAR_TITLE_WIDTH_PERCENT definition to (HOME_SCREEN_DEEP_STATUS_BAR ? 40 : 57) for parity with the updated code I think.

Once rebased/updated I'm happy to merge thanks.

@oroderico
oroderico force-pushed the test-pr274-home-fingerprint-no-jade branch from e15c7f4 to 6464d01 Compare September 18, 2026 09:48
@oroderico

Copy link
Copy Markdown
Contributor Author

Rebased onto master and updated HOME_SCREEN_STATUS_BAR_TITLE_WIDTH_PERCENT to (HOME_SCREEN_DEEP_STATUS_BAR ? 40 : 57) to match the widened deep status bar split. Ready for another look whenever you get a chance, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants