Conversation
snprintf() titles for the mnemonic restore flow (word selection, confirmation, insertion, and word-number restore) used %zu for size_t arguments. On at least ESP32-S3 boards this renders the raw "zu" characters instead of the value (e.g. "Word zu/zu"), observed on a Waveshare S3 Touch LCD2. Cast to unsigned int and use %u instead, which is unambiguous on this 32-bit target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snprintf() titles in the mnemonic restore flow (select/confirm/insert
word, and the word-number restore method from #312) used %zu for
size_t args. On ESP32-S3 (tested on Waveshare S3 Touch LCD2) this
renders literally as "zu" instead of the number, e.g. "Word zu/zu".
Cast to unsigned int and use %u instead.
Tested on device: titles now render correctly in both the normal
typed restore and the word-number restore flow.