Repository navigation
Conversation
|
| Filename | Overview |
|---|---|
| src/BloomBrowserUI/bookEdit/css/editMode.less | Adds trim-only clipping and hover-revealed bleed, safety, and crop-mark styling; no actionable defect was identified. |
Reviews (1): Last reviewed commit: "BL-15958 Show trim-only view in edit mod..." | Re-trigger Greptile
|
[Claude Opus 5.5 from Hatton's machine during preflight] Consulted Devin on 2026-10-07 21:05 UTC up to commit 40cc926. It raised one bug (bottom and right safety strips hidden) and one investigate flag (target branch). Both are assessed as not an issue, with the reasoning on their threads, which are now resolved. No informational flags. |
|
[Claude Opus 5.5 from Hatton's machine during preflight] Preflight report: https://bloombooks.github.io/dev-process-artifacts/deciders/bloomdesktop-bl-15958-crop-marks.html |
hatton
left a comment
There was a problem hiding this comment.
@hatton+JHAI resolved 2 discussions.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.
40cc926 to
a170d9f
Compare
…n hover For books with full bleed on, the Edit tab now shows each paper-size page as it will look after trimming. Hovering over the page reveals the 3mm bleed band, faint safety-area strips just inside the trim line, and white crop marks at the corners. Ebook and device sizes get none of this. The rules live in bookEdit/css/bleedAndCropMarks.less, imported by editMode.less, and select paper sizes with .bloom-mediaBox:not([class*="Device"], [class*="Ebook"]). The mediaBox carries only the page size class, so the substring match picks out exactly the screen sizes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
a170d9f to
4934278
Compare
[Claude Opus 5.5 from Hatton's machine during preflight]
Problem. For a book with Use full bleed page layout on, the Edit tab showed each page at its full printed size, with a thick dark band over the outer 3mm that the printer cuts off. Authors were always looking at a page larger than the finished one, with the edges of their pictures dimmed.
What the PR does.
bookEdit/css/bleedAndCropMarks.less, imported byeditMode.less. They pick out paper sizes with one test on the page-size class name,:not([class*="Device"], [class*="Ebook"]), instead of naming the four screen sizes. The mediaBox element carries only the page-size class (HtmlDom.cs), so no other class can match.This is one of three independent PRs for BL-15958; the others are #8262 and #8263, both merged.
Screenshots
An A5 full-bleed page in the Edit tab. Without the mouse over the page, it shows the trimmed page (left). With the mouse over it, the 3mm bleed band, the faint strip just inside the cut line, and the crop marks at the corners appear (right).
The top-left corner at 300% zoom, with the mouse over the page, showing the white crop marks in the bleed band:
Risk Evaluation
Low. The change is CSS loaded only in the Edit tab, and it does nothing unless the book has full bleed on. Hiding the outer 3mm until the page is hovered is the one thing to watch: a control or handle sitting in that strip (a Canvas item dragged to the edge, a picture's buttons near a corner) is hidden until the mouse is over the page.
Ecosystem Impact
None.
editMode.cssis never put into a book or published, so PDF, BloomPUB, ePUB, Bloom Player and older Bloom versions are unaffected. No new strings and no dependency changes.E2E Coverage
No e2e test covers full-bleed pages in the Edit tab, and none was added: the behavior is a hover-dependent visual, which the e2e suite does not check. The manual test ideas on the card cover it.
Notion Test Suite
None.
Preflight report: https://bloombooks.github.io/dev-process-artifacts/deciders/bloomdesktop-bl-15958-crop-marks.html
Devin review
This change is