[nyoungbq]

Fixes: #992

This PR addresses the request. Confirmed via direct feedback.

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file simplnx/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file simplnx/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

• 1 Unit test to test output from the filter against known exemplar set of data
• 1 Unit test to test invalid input code paths that are specific to a filter. Don't test that a DataPath does not exist since that test is already performed as part of the SelectDataArrayAction.

Code Cleanup

• No commented out code (rare exceptions to this is allowed..)
• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)
• Added test (or behavior not changed)
• Updated API documentation (or API not changed)
• Added license to new files (if any)
• Added example pipelines that use the filter
• Classes and methods are properly documented

[imikejackson]

Superseded. I am taking over this filter.

Superseded by a redesign of the filter.

[imikejackson]

This PR is replaced by #1890.

The new filter is Compute C-Axis Reference Misalignments. It uses a quaternion array, a Phases array and a Crystal Structures array as its input, so it works on cell orientations and feature average orientations. This PR used a 3-component c-axis array as its input, so the filter also accepted Euler angles and gave incorrect angles. #1890 keeps Nathan's work as a co-author on the commit.

Continue the review on #1890.