Repository navigation
BUG: Restrict file extensions of RegularizeZSpacingFilter and ReadOnScaleTableFileFilter - #1897
Open
imikejackson wants to merge 1 commit into
Open
imikejackson wants to merge 1 commit into
imikejackson wants to merge 1 commit into
Conversation
imikejackson
changed the title
imikejackson
enabled auto-merge (squash)
October 30, 2026 12:58
DREAM3D-NX offers a filter for every dropped file or folder when the input file parameter of the filter accepts all extensions. These two filters set that option, so they showed for each drop. * RegularizeZSpacingFilter accepts only .txt, .dat and .csv files. * ReadOnScaleTableFileFilter accepts only .flxtbl files. * Add tests for the supported extensions and for the -3003 preflight error that an unsupported extension causes. * Update the filter documentation and the Regularize Z Spacing V&V notes. Converted legacy pipelines that use a different extension now fail preflight and must use a renamed file. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/file_drop_extensions
branch
from
October 30, 2026 12:58
00ba354 to
76d75ea
Compare
imikejackson
marked this pull request as draft
October 30, 2026 13:00
auto-merge was automatically disabled
October 30, 2026 13:00
Pull request was converted to draft
imikejackson
marked this pull request as ready for review
October 30, 2026 13:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a file input parameter accepts all extensions, DREAM3D-NX offers its filter for every file or folder that is dropped on the pipeline area. Regularize Z Spacing and Read OnScale Table File set this option, so they showed for every drop. This change makes the two filters accept only the extensions they list.
RegularizeZSpacingFilteraccepts only.txt,.dat, and.csvfiles for the Z positions file.ReadOnScaleTableFileFilteraccepts only.flxtblfiles..datand.csvZ positions files run, and that an unsupported extension fails preflight with error-3003. The OnScale test case for a.tablefile now expects error-3003.Behavior change: a converted legacy pipeline that uses a Z positions file with a different extension now fails preflight. An unsupported extension gives error
-3003, and a file with no extension gives error-3002. Rename the file to a supported extension to fix this.The DREAM3D-NX change that adds folder drops is BlueQuartzSoftware/DREAM3DNX#1225. That pull request does not depend on this one.
Test Plan
SimplnxCoreUnitTestbuilds on macOS (NX-Com-Qt69-Vtk96-Rel).ctest -R "SimplnxCore::RegularizeZSpacing|SimplnxCore::ReadOnScaleTableFile"passes (22/22).Related Issue