Skip to content

Update the dapp and console for the renamed request arguments #341

Open

Description

@luchobonatti

User story / Problem statement

Currently, the dapp and the console call the vault with from, caller and controller argument names, and pass a caller argument to 28 admin entrypoints that no longer take one. #323 renames the request arguments to holder and caller, and #325 drops the caller argument from those admin entrypoints. The UI builds its clients from the deployed testnet contracts, so it keeps working until the redeploy; then the old names and extra arguments fail.

Expected outcome

After regenerating the clients from a deployment with the new specs, every dapp and console call uses the new argument names and no longer passes the removed caller.

Acceptance criteria

Argument renames:

  • request_deposit, cancel_deposit, request_redeem, cancel_redeem pass holder (was from)
  • claim_deposit, claim_redeem pass holder (was caller)
  • get_deposit_request, get_redeem_request pass holder (was controller)
  • fund passes caller (was from)
  • legal_transfer and the compliance admin calls pass caller where the console uses them (Move the console's compliance transfer to legal transfer #338)

Dropped caller argument:

  • set_custodian, set_notice, set_wind_down_delay, set_deposit_cap, propose_wind_down, cancel_wind_down_proposal, propose_change, cancel_change, apply_change, finish_setup no longer pass caller
  • bind_vault, finish_setup, propose_change, cancel_change, apply_change on the token, oracle, compliance and verifier no longer pass caller
  • identity_verifier.allow no longer passes caller
  • unpause (vault), pause, unpause, set_compliance, set_identity_verifier (token) keep caller but as the admin only

Technical notes

  • Investor dapp: app/src/hooks/useRequestDeposit.ts:21, useCancelRedeem.ts:21, useClaimDeposit.ts:21
  • Event topic renames do not affect the UI: it reads topics by position
  • CI typechecks the app against the deployed testnet specs, so this only breaks after the redeploy

Additional context

Follow-up to #272 / #323 and #274 / #325. Covers the investor dapp and the admin console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions