Repository navigation
fix: extend the token, verifier and compliance ttl - #246
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
marked this pull request as ready for review
October 16, 2026 23:41
luchobonatti
approved these changes
Oct 20, 2026
luchobonatti
left a comment
Member
There was a problem hiding this comment.
- M-09 (new balances not extended on creation) seems out of scope here. Is it planned for another PR or upstream?
| } | ||
|
|
||
| /// OpenZeppelin leaves the instance's lifetime to the token, so every call | ||
| /// that moves shares extends it before handing over to the library. |
Member
There was a problem hiding this comment.
Maybe also extend in balance and total_supply? A later wind-down claim only reads balance, so a quiet wind-down could still let the instance lapse.
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
@luchobonatti On new balances not being extended when they are created: it's in this stack, in #276. Every call that writes a share balance or a freeze, and every role grant, reads the entry back through OpenZeppelin's own reads, so a new entry reaches its extend target in the transaction that creates it. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #268
The share token, the compliance stub and the identity verifier never extended their instance TTL. The vault and oracle extend theirs; these three did not, and on testnet their instances already read as archived. Every call that does work on them now extends the instance to 30 days, like the vault. The runbook and the written TTL policy follow in the next PR.
Changes
Acceptance criteria
Test plan
Automated tests
SOROBAN_SDK_BUILD_SYSTEM_SUPPORTS_SPEC_SHAKING_V2=1 cargo test --locked*_instance_ttlones.Manual verification
None; the testnet redeploy comes with the group release.
Breaking changes
None.
Checklist
Screenshots
None.