Repository navigation
docs: fix what a Tranche 1 reviewer flagged - #308
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hpmaxi
self-requested a review
October 22, 2026 15:30
hpmaxi
approved these changes
Oct 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #307
A Tranche 1 reviewer found two misleading docs: the authorization section of
TESTING.mdreads as if role scenarios are not tested, and formulas inkit-spec.mdfail to render on GitHub.Changes
Acceptance criteria
TESTING.mdseparates role checks from signature checks and points to the authorization matrixkit-spec.mdshows a syntax error on GitHubTest plan
Automated tests
npx prettier --check docs/kit-spec.md docs/TESTING.mdpasses with the repo config.Manual verification
docs/kit-spec.mdin this PR's "Files changed" view, rich diff.'_' allowed only in math mode.Breaking changes
None.
Checklist
Screenshots
None.